Add Matter water valve support and example sketch - #182
Merged
Tamas Jozsi (silabs-bozont) merged 3 commits intoAug 24, 2026
Merged
Add Matter water valve support and example sketch#182Tamas Jozsi (silabs-bozont) merged 3 commits into
Tamas Jozsi (silabs-bozont) merged 3 commits into
Conversation
Tamas Jozsi (silabs-bozont)
added
the
Community contribution
Ludovic BOUÉ (lboue)
marked this pull request as ready for review
July 6, 2026 16:11
Ludovic BOUÉ (lboue)
requested a review
from Tamas Jozsi (silabs-bozont)
as a code owner
July 6, 2026 16:11
Tamas Jozsi (silabs-bozont)
added
Under review
Tamas Jozsi (silabs-bozont)
requested changes
Jul 22, 2026
Tamas Jozsi (silabs-bozont)
left a comment
Tamas Jozsi (silabs-bozont)
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for implementing this - it'll be a great addition to the library. I've tested it with Home Assistant - works as expected. I had a few minor remarks, after fixing them we're good to go.
Ludovic BOUÉ (lboue)
force-pushed
the
Matter-WaterValve
branch
from
July 22, 2026 11:29
0feac94 to
067c73a
Compare
Contributor
Author
|
Push fixes into 067c73a |
Restricts the public setter to defined fault values instead of an arbitrary uint16_t, per PR review feedback. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
OpenDuration, DefaultOpenDuration, RemainingDuration, CurrentState and TargetState are all nullable per spec, and OpenDuration/DefaultOpenDuration have a min value of 1, so "no duration configured" must be represented as null rather than 0. Without ATTRIBUTE_MASK_NULLABLE, writes of null (e.g. clearing DefaultOpenDuration from Home Assistant) were rejected. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Tamas Jozsi (silabs-bozont)
added
the
Run CI Matter
Tamas Jozsi (silabs-bozont)
approved these changes
Aug 24, 2026
Collaborator
|
Just noticed that the docs are missing for this from the library's |
3 tasks
Tamas Jozsi (silabs-bozont)
merged commit Aug 24, 2026
23c6291
into
SiliconLabsSoftware:main
5 checks passed
Tamas Jozsi (silabs-bozont)
removed
the
Under review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Matter Water Valve support
Summary
MatterWaterValveArduino API on top of the Matter Valve Configuration and Control cluster (device type0x0042), following the existingDevice/MatterEndpointpattern used by other Matter appliances in this core.DeviceWaterValveclass (libraries/Matter/src/devices/DeviceWaterValve.{h,cpp}) implementingCurrentState,TargetState,OpenDuration,DefaultOpenDuration,RemainingDuration, andValveFaultattributes, plusHandleReadEmberAfAttribute/HandleWriteEmberAfAttributeoverrides.MatterWaterValve.{h,cpp}with a public API to open the valve indefinitely or for a set duration, close it, and read/write duration and fault state, along with a command handler for the cluster'sOpen/Closecommands.MatterEndpoint.h(DEVICE_TYPE_WATER_VALVE) anddevices/MatterDevice.h(kDeviceType_WaterValve).matter_watervalveexample sketch demonstrating commissioning, opening the valve with a countdown duration, closing it, and mirroring valve state on the built-in LED.test/build/test_build.pyundertestlist_matterso it's built by CI across all Matter-capable boards.